Adds configuration option to exclude the webserver on esp32. #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
caveman99
requested changes
Mar 11, 2024
|
@caveman99, I'm not sure what I'm to do about these failing CI checks on files I haven't changed. Can you offer any insight? I've got some additional changes lined up to facilitate minimal builds using the pattern you've initiated (build w/o BT, Wifi, GPS) but I'm struggling to understand what mistake I'm making here. thx |
This reverts commit 436e631.
caveman99
approved these changes
Mar 20, 2024
thebentern
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to the suggestion by @caveman99 to make including the webserver optional on esp32. Excluding the webserver saves about 8kb of flash on the device and disables the web app and the TCP API. TCP (via wifi or ethernet) remains enabled for use by NTP or MQTT if needed. Tested with tbeam and tlora-v2-1-1_6 devices.